[webkit-reviews] review granted: [Bug 245399] SVG animations should respect Page::imageAnimationEnabled : [Attachment 462456] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Tyler Wilcock <tyler_w at apple.com>'s
request for review:
Bug 245399: SVG animations should respect Page::imageAnimationEnabled
https://bugs.webkit.org/show_bug.cgi?id=245399

Attachment 462456: Patch

https://bugs.webkit.org/attachment.cgi?id=462456&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 462456
  --> https://bugs.webkit.org/attachment.cgi?id=462456
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462456&action=review

> Source/WebCore/svg/SVGAnimateElementBase.cpp:159
> +    if (auto* page = document().page()) {
> +	   if (!page->imageAnimationEnabled())
> +	       return;
> +    }

This can be written less nested:

    if (auto* page = document().page(); page && !page->imageAnimationEnabled())
	return;

> Source/WebCore/svg/animation/SVGSMILElement.cpp:1091
> +    if (auto* page = document().page()) {
> +	   if (!page->imageAnimationEnabled()) {

Ditto.