[webkit-reviews] review granted: [Bug 244706] CSS - overflow: clip is not working on SVG elements : [Attachment 462199] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 8 13:06:51 PDT 2022


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 244706: CSS - overflow: clip is not working on SVG elements
https://bugs.webkit.org/show_bug.cgi?id=244706

Attachment 462199: Patch

https://bugs.webkit.org/attachment.cgi?id=462199&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 462199
  --> https://bugs.webkit.org/attachment.cgi?id=462199
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462199&action=review

> Source/WebCore/rendering/style/RenderStyle.h:2553
> +inline bool isNonVisibleOverflow(const Overflow& overflow)

Overflow is a uint8_t enum, so it's more efficient to pass by value.


More information about the webkit-reviews mailing list