[webkit-reviews] review granted: [Bug 244782] [LFC][IFC] Move overflowing float boxes to the next line : [Attachment 462134] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 244782: [LFC][IFC] Move overflowing float boxes to the next line
https://bugs.webkit.org/show_bug.cgi?id=244782

Attachment 462134: Patch

https://bugs.webkit.org/attachment.cgi?id=462134&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 462134
  --> https://bugs.webkit.org/attachment.cgi?id=462134
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462134&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:937
> +	   // we can still continue placing inline content on the line, but we
have to save all the upcoming floats for subsequent lines.
> +	   auto lineHasSkippedFloats = !m_overflowingFloats.isEmpty();
> +	   if (lineHasSkippedFloats)
> +	       return false;
> +	   if (lineBoxConstraintApplies == LineBoxConstraintApplies::No) {
> +	       // This is an overflowing float from previous line. Now we need
to find a place for it.
> +	       return true;
> +	   }

maybe we can assert these conditions are mutually exclusive