[webkit-reviews] review granted: [Bug 244746] AX: Stop unnecessarily caching AXPropertyName::{LayoutCount, PressedIsPresent, DropEffects, ClickPoint, ClassList} : [Attachment 462108] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted  review:
Bug 244746: AX: Stop unnecessarily caching AXPropertyName::{LayoutCount,
PressedIsPresent, DropEffects, ClickPoint, ClassList}
https://bugs.webkit.org/show_bug.cgi?id=244746

Attachment 462108: Patch

https://bugs.webkit.org/attachment.cgi?id=462108&action=review




--- Comment #3 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 462108
  --> https://bugs.webkit.org/attachment.cgi?id=462108
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462108&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:3150
> +    for (unsigned k = 0; k < domClassList.length(); k++)

Can we put length outside the loop to reduce number of times it is called

> Source/WebCore/accessibility/AccessibilityObject.cpp:3151
> +	   classList.append(domClassList.item(k).string());

Is there some existing map function that does this?