[webkit-reviews] review granted: [Bug 247081] Top scoreboard of espn.com cutting off team names : [Attachment 463261] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 247081: Top scoreboard of espn.com cutting off team names
https://bugs.webkit.org/show_bug.cgi?id=247081

Attachment 463261: Patch

https://bugs.webkit.org/attachment.cgi?id=463261&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 463261
  --> https://bugs.webkit.org/attachment.cgi?id=463261
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463261&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:585
> -	   if (!lineHasOverflow || isInIntrinsicWidthMode)
> +	   auto lineHasOverflowAfterTrimmingTrailingContent =
horizontalAvailableSpace < m_line.contentLogicalWidth();
> +	   if (!lineHasOverflowAfterTrimmingTrailingContent ||
isInIntrinsicWidthMode)

Maybe this function should be refactored a bit, for example split into
before-trimming and after-trimming parts? It is kinda confusing there is a
lineHasOverflow variable in the scope that has incorrect value.