[webkit-reviews] review granted: [Bug 246604] [WinCairo] Use RenderThemeAdwaita instead of RenderThemeWin : [Attachment 463066] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 246604: [WinCairo] Use RenderThemeAdwaita instead of RenderThemeWin
https://bugs.webkit.org/show_bug.cgi?id=246604

Attachment 463066: Patch

https://bugs.webkit.org/attachment.cgi?id=463066&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 463066
  --> https://bugs.webkit.org/attachment.cgi?id=463066
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463066&action=review

> Source/WebCore/rendering/RenderThemeAdwaita.cpp:241
> +#elif PLATFORM(WIN)

The code below doesn’t look platform-specific. Can we instead just use "#else"
here? Or is this actively specific to PLATFORM(WIN)?

> Source/WebCore/rendering/RenderThemeAdwaita.cpp:243
> +    if (!path)

Typically it’s best to check isNull() instead of using ! for WTF::String. But
also, maybe FileSystem::readEntireFile already harmlessly fails if passed a
null string, so maybe we don’t need this check.