[webkit-reviews] review granted: [Bug 229697] keyboard scrolling spring damping animation doesn't finish and leads to endless flickering scrolling : [Attachment 462846] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 229697: keyboard scrolling spring damping animation doesn't finish and
leads to endless flickering scrolling
https://bugs.webkit.org/show_bug.cgi?id=229697

Attachment 462846: Patch

https://bugs.webkit.org/attachment.cgi?id=462846&action=review




--- Comment #20 from Tim Horton <thorton at apple.com> ---
Comment on attachment 462846
  --> https://bugs.webkit.org/attachment.cgi?id=462846
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462846&action=review

> Source/WebCore/platform/KeyboardScrollingAnimator.cpp:223
> +    if (axesToApplySpring.width() && displacement.width() *
newDisplacement.width() < 0)

This is fine, though I bet you want an areEssentiallyEqual / FLT_EPSILON /
whatever?

(Also separately super confused about what's going on with your frame times,
and why this was never necessary on iOS (not sure if there was a mistake when
the code got moved here, or what)). But that's ok!

Thank you for fixing.