[webkit-reviews] review granted: [Bug 248482] AX: add to AXLogger the ability to filter the output by keywords. : [Attachment 463793] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 248482: AX: add to AXLogger the ability to filter the output by keywords.
https://bugs.webkit.org/show_bug.cgi?id=248482

Attachment 463793: Patch

https://bugs.webkit.org/attachment.cgi?id=463793&action=review




--- Comment #4 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 463793
  --> https://bugs.webkit.org/attachment.cgi?id=463793
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463793&action=review

> Source/WebCore/accessibility/AXLogger.cpp:59
> +	   auto it = std::find_if(nameFilter->begin(), nameFilter->end(),
[this] (const auto& name) {

can you choose a more descriptive variable name (instead of 'it')