[webkit-reviews] review granted: [Bug 248015] [LFC][IFC] Introduce a fast path for finding breaking position when text content uses fixed pitch font : [Attachment 463583] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 248015: [LFC][IFC] Introduce a fast path for finding breaking position when
text content uses fixed pitch font
https://bugs.webkit.org/show_bug.cgi?id=248015

Attachment 463583: Patch

https://bugs.webkit.org/attachment.cgi?id=463583&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 463583
  --> https://bugs.webkit.org/attachment.cgi?id=463583
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463583&action=review

> Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:246
> +		   size_t estimatedCharacterCount = availableWidth /
monospaceCharacterWidth;

An explicit floor() would make this slightly more self-explanatory