[webkit-reviews] review canceled: [Bug 248289] [CMake][Win] Use CMAKE_MSVC_RUNTIME_LIBRARY to select a CRT type instead of regexp replacing : [Attachment 463699] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 23 16:49:02 PST 2022


Fujii Hironori <Hironori.Fujii at sony.com> has canceled Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 248289: [CMake][Win] Use CMAKE_MSVC_RUNTIME_LIBRARY to select a CRT type
instead of regexp replacing
https://bugs.webkit.org/show_bug.cgi?id=248289

Attachment 463699: Patch

https://bugs.webkit.org/attachment.cgi?id=463699&action=review




--- Comment #2 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 463699
  --> https://bugs.webkit.org/attachment.cgi?id=463699
Patch

Umm, jsc EWS failed.

> CMake Error at Source/JavaScriptCore/CMakeLists.txt:2 (cmake_policy):
>   Policy "CMP0091" is not known to this version of CMake.


More information about the webkit-reviews mailing list