[webkit-reviews] review granted: [Bug 248190] CMake 3.25.0: ninja: error: dependency cycle: Source/WebCore/CMakeFiles/WebCore.dir/CXX.dd : [Attachment 463650] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 21 20:18:47 PST 2022


Ross Kirsling <ross.kirsling at sony.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 248190: CMake 3.25.0: ninja: error: dependency cycle:
Source/WebCore/CMakeFiles/WebCore.dir/CXX.dd
https://bugs.webkit.org/show_bug.cgi?id=248190

Attachment 463650: Patch

https://bugs.webkit.org/attachment.cgi?id=463650&action=review




--- Comment #5 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 463650
  --> https://bugs.webkit.org/attachment.cgi?id=463650
Patch

r=me, seems fine based on the quote you gave.


More information about the webkit-reviews mailing list