[webkit-reviews] review granted: [Bug 246852] [GTK] Crash on authentication dialog with GTK 4 : [Attachment 463532] fix gtk4 auth dialog crashes. take two
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 15 09:27:25 PST 2022
Michael Catanzaro <mcatanzaro at gnome.org> has granted enometh at meer.net's request
for review:
Bug 246852: [GTK] Crash on authentication dialog with GTK 4
https://bugs.webkit.org/show_bug.cgi?id=246852
Attachment 463532: fix gtk4 auth dialog crashes. take two
https://bugs.webkit.org/attachment.cgi?id=463532&action=review
--- Comment #15 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 463532
--> https://bugs.webkit.org/attachment.cgi?id=463532
fix gtk4 auth dialog crashes. take two
OK, your changelog format in your commit message is a little weird, but I don't
care.
You have one remaining style error to fix:
ERROR: Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1889: One line
control clauses should not use braces. [whitespace/braces] [4]
More information about the webkit-reviews
mailing list