[webkit-reviews] review granted: [Bug 247875] REGRESSION(255715 at main) [WinCairo] TestWebCore.WebCoreBundleTest.BundlePathFromNameTypeDirectory is failing : [Attachment 463512] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 247875: REGRESSION(255715 at main) [WinCairo]
TestWebCore.WebCoreBundleTest.BundlePathFromNameTypeDirectory is failing
https://bugs.webkit.org/show_bug.cgi?id=247875

Attachment 463512: Patch

https://bugs.webkit.org/attachment.cgi?id=463512&action=review




--- Comment #2 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 463512
  --> https://bugs.webkit.org/attachment.cgi?id=463512
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463512&action=review

r=me with a comment, given that the GTK failure seems to be an existing flaky
test.

> Tools/TestWebKitAPI/Tests/WebCore/win/WebCoreBundle.cpp:70
> +    actual = WebCore::webKitBundlePath("Localizable"_s, "strings"_s, ""_s);
> +    expected = FileSystem::pathByAppendingComponents(m_root, { "en.lproj"_s,
"Localizable.strings"_s });
> +    EXPECT_STREQ(expected.utf8().data(), actual.utf8().data());

These lines don't need #if ENABLE(MODERN_MEDIA_CONTROLS)?