[webkit-reviews] review granted: [Bug 240755] [CMake] Cannot link WebKitTestRunner in non-unified builds : [Attachment 459767] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 240755: [CMake] Cannot link WebKitTestRunner in non-unified builds
https://bugs.webkit.org/show_bug.cgi?id=240755

Attachment 459767: Patch

https://bugs.webkit.org/attachment.cgi?id=459767&action=review




--- Comment #5 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 459767
  --> https://bugs.webkit.org/attachment.cgi?id=459767
Patch

Thanks, Fujii! Patch LGTM with a small bit to do before landing.


View in context: https://bugs.webkit.org/attachment.cgi?id=459767&action=review

> Source/WebCore/PlatformGTK.cmake:-9
> -set(WebCore_OUTPUT_NAME WebCoreGTK)

I have no about the reason for this. It was added in the patch
for bug #144364 but there is no explanation why ��‍♂️️ -- The WPE port
leaves the output name for WebCore unchanged and things work just
fine.

> Source/cmake/OptionsGTK.cmake:250
> +set(WebCore_LIBRARY_TYPE OBJECT)

We should apply the same change in OptionsWPE.cmake :)