[webkit-reviews] review granted: [Bug 240728] [Repaint] Do not issue repaint when the ancestor layer has already been scheduled for one : [Attachment 459652] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 23 16:22:24 PDT 2022


Simon Fraser (smfr) <simon.fraser at apple.com> has granted  review:
Bug 240728: [Repaint] Do not issue repaint when the ancestor layer has already
been scheduled for one
https://bugs.webkit.org/show_bug.cgi?id=240728

Attachment 459652: Patch

https://bugs.webkit.org/attachment.cgi?id=459652&action=review




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 459652
  --> https://bugs.webkit.org/attachment.cgi?id=459652
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459652&action=review

> Source/WebCore/rendering/RenderLayer.cpp:2050
> +    return { false, nullptr };

Could just return { }

> Source/WebCore/rendering/RenderLayer.h:594
> +	   bool fullRepaintIsScheduled { false };

Maybe fullRepaintAlreadyScheduled or dueForFullRepaint?


More information about the webkit-reviews mailing list