[webkit-reviews] review granted: [Bug 240610] REGRESSION (r294160): Occasional infinite loops under updateLayersForInteractionRegions : [Attachment 459560] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 240610: REGRESSION (r294160): Occasional infinite loops under
updateLayersForInteractionRegions
https://bugs.webkit.org/show_bug.cgi?id=240610

Attachment 459560: Patch

https://bugs.webkit.org/attachment.cgi?id=459560&action=review




--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 459560
  --> https://bugs.webkit.org/attachment.cgi?id=459560
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459560&action=review

Seems reasonable to me!

> Source/WebCore/platform/graphics/IntRectHash.h:49
> +    static WebCore::IntRect emptyValue() { return { -2, -2, -2, -2 }; }

Out of curiosity, is there a reason why we opt for this value?

(CoreGraphics has a notion of `CGRectNull` that's something along the lines of
{ 0, 0, ∞, ∞ }, for instance)