[webkit-reviews] review granted: [Bug 240478] check-webkit-style: validate enums declared with explicit type : [Attachment 459453] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 17 12:16:30 PDT 2022
Devin Rousso <drousso at apple.com> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 240478: check-webkit-style: validate enums declared with explicit type
https://bugs.webkit.org/show_bug.cgi?id=240478
Attachment 459453: Patch
https://bugs.webkit.org/attachment.cgi?id=459453&action=review
--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 459453
--> https://bugs.webkit.org/attachment.cgi?id=459453
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=459453&action=review
rs=mews
> Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:4396
> + '''enum class Type : uint8_t { FIRST, SECOND };''',
i'd include some valid test cases too (e.g. `enum class Foo : uint8_t { First,
Second }`)
More information about the webkit-reviews
mailing list