[webkit-reviews] review granted: [Bug 240459] [WebAuthn] Set displayName in AuthenticatorAssertionResponse for platform authenticator : [Attachment 459442] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 17 09:58:23 PDT 2022


Brent Fulgham <bfulgham at webkit.org> has granted j_pascoe at apple.com
<j_pascoe at apple.com>'s request for review:
Bug 240459: [WebAuthn] Set displayName in AuthenticatorAssertionResponse for
platform authenticator
https://bugs.webkit.org/show_bug.cgi?id=240459

Attachment 459442: Patch

https://bugs.webkit.org/attachment.cgi?id=459442&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 459442
  --> https://bugs.webkit.org/attachment.cgi?id=459442
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459442&action=review

r=me

> Source/WebKit/ChangeLog:3
> +	   [WebAuthn] Set displayName in AuthenticatorAssertionResponse for
platform authenticator

Question: I'm not sure how setting the displayName here "prevents the display
name from being passed to the UI". Did the bug mean to say "prevents the user
name from being passed to the UI?"


More information about the webkit-reviews mailing list