[webkit-reviews] review granted: [Bug 240056] SharedMemory::IPCHandle is a redundant class : [Attachment 459305] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 16 14:17:06 PDT 2022
Fujii Hironori <Hironori.Fujii at sony.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 240056: SharedMemory::IPCHandle is a redundant class
https://bugs.webkit.org/show_bug.cgi?id=240056
Attachment 459305: Patch
https://bugs.webkit.org/attachment.cgi?id=459305&action=review
--- Comment #14 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 459305
--> https://bugs.webkit.org/attachment.cgi?id=459305
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=459305&action=review
> Source/WebKit/Shared/WebCompiledContentRuleListData.cpp:37
> + return topURLFiltersBytecodeOffset + topURLFiltersBytecodeSize;
Do you think this addition needs overflow checking?
> Source/WebKit/Shared/WebCompiledContentRuleListData.cpp:112
> + if (data->size() < ruleListDataSize(*topURLFiltersBytecodeOffset,
*topURLFiltersBytecodeSize))
data->size() is a data size, not buffer size. I think it should (data->size()
== ruleListDataSize(...)). If the condition fails, something wrong happens.
> Tools/MiniBrowser/mac/WK2BrowserWindowController.m:556
> + title = @"";
Do you want to change MiniBrowser in this patch?
More information about the webkit-reviews
mailing list