[webkit-reviews] review granted: [Bug 211787] Perspective should not be affected by transform-origin : [Attachment 457251] Patch, v7

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 211787: Perspective should not be affected by transform-origin
https://bugs.webkit.org/show_bug.cgi?id=211787

Attachment 457251: Patch, v7

https://bugs.webkit.org/attachment.cgi?id=457251&action=review




--- Comment #15 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 457251
  --> https://bugs.webkit.org/attachment.cgi?id=457251
Patch, v7

View in context: https://bugs.webkit.org/attachment.cgi?id=457251&action=review

> Source/WebCore/rendering/RenderLayer.cpp:1815
> +    // To circumvent this, explicitely remove the transform-origin
dependency in the perspective matrix.
> +    auto transformOrigin = transformOriginForPainting();

If this function isn't returning the "perspectiveTransform", but rather
something that makes assumptions about platform-specific rendering, perhaps it
needs to be renamed?

> Source/WebCore/rendering/RenderLayer.cpp:1824
> +FloatPoint3D RenderLayer::transformOriginForPainting() const

Unclear how this relates to the other kind of "transform origin". Is it just
about snapping?

> Source/WebCore/rendering/RenderLayer.h:743
>      // Note that this transform has the perspective-origin baked in.

Is this comment still accurate?