[webkit-reviews] review granted: [Bug 240388] computeIntrinsicLogicalContentHeightUsing doesn't take intrinsicBorderForFieldset() into account : [Attachment 459312] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Oriol Brufau <obrufau at igalia.com>'s
request for review:
Bug 240388: computeIntrinsicLogicalContentHeightUsing doesn't take
intrinsicBorderForFieldset() into account
https://bugs.webkit.org/show_bug.cgi?id=240388

Attachment 459312: Patch

https://bugs.webkit.org/attachment.cgi?id=459312&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 459312
  --> https://bugs.webkit.org/attachment.cgi?id=459312
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459312&action=review

> Source/WebCore/rendering/RenderBox.cpp:3269
>	   return intrinsicContentHeight;

After the refactoring, this could just be return std::nullopt, and I think it’s
clearer that way.