[webkit-reviews] review granted: [Bug 240421] MockAudioSharedInternalUnit should exit early when being stopped in generateSampleBuffers : [Attachment 459358] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 240421: MockAudioSharedInternalUnit should exit early when being stopped in
generateSampleBuffers
https://bugs.webkit.org/show_bug.cgi?id=240421

Attachment 459358: Patch

https://bugs.webkit.org/attachment.cgi?id=459358&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 459358
  --> https://bugs.webkit.org/attachment.cgi?id=459358
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459358&action=review

> Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm:150
> +    Ref<MockAudioSharedInternalUnitState> m_isProducingState;

Nit: `m_isProducingState` doesn't seem right, maybee `m_internalState`?