[webkit-reviews] review granted: [Bug 240401] [Repaint] Border ignores currentColor change when hovering : [Attachment 459337] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 14 05:39:53 PDT 2022

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 240401: [Repaint] Border ignores currentColor change when hovering

Attachment 459337: Patch


--- Comment #6 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 459337
  --> https://bugs.webkit.org/attachment.cgi?id=459337

View in context: https://bugs.webkit.org/attachment.cgi?id=459337&action=review

> Source/WebCore/rendering/style/BorderData.h:114
> +	   return !currentColorDiffers || (m_top.color().isValid() &&
m_right.color().isValid() && m_bottom.color().isValid() &&

Might be more stylish to use RenderStyle::isCurrentColor(m_top.color()) etc.

More information about the webkit-reviews mailing list