[webkit-reviews] review granted: [Bug 240404] ApplePayLogoSystemImage needlessly loads PassKit in WebKit child processes on iOS : [Attachment 459333] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 13 17:12:06 PDT 2022


Chris Dumez <cdumez at apple.com> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 240404: ApplePayLogoSystemImage needlessly loads PassKit in WebKit child
processes on iOS
https://bugs.webkit.org/show_bug.cgi?id=240404

Attachment 459333: Patch

https://bugs.webkit.org/attachment.cgi?id=459333&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 459333
  --> https://bugs.webkit.org/attachment.cgi?id=459333
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459333&action=review

r=me

> Source/WTF/wtf/cocoa/FileSystemCocoa.mm:241
> +    static NeverDestroyed<RetainPtr<NSString>> path = adoptNS([^{

Why use adoptNS() + copy? Can we just assign the NSString* to the RetainPtr<>
right away?


More information about the webkit-reviews mailing list