[webkit-reviews] review granted: [Bug 240334] Add logging when taking a process assertion synchronously : [Attachment 459214] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 13 07:25:28 PDT 2022

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 240334: Add logging when taking a process assertion synchronously

Attachment 459214: Patch


--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 459214
  --> https://bugs.webkit.org/attachment.cgi?id=459214

View in context: https://bugs.webkit.org/attachment.cgi?id=459214&action=review

> Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:370
> +    RELEASE_LOG(ProcessSuspension, "%p - ProcessAssertion: Trying to take
RBS assertion '%{public}s' for process with PID=%d", this,
m_reason.utf8().data(), m_pid);

Please put method name in the logging:
ProcessAssertion::acquireSync: not ProcessAssertion:

More information about the webkit-reviews mailing list