[webkit-reviews] review granted: [Bug 240056] SharedMemory::IPCHandle is a redundant class : [Attachment 459281] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 13 00:28:39 PDT 2022
Fujii Hironori <Hironori.Fujii at sony.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 240056: SharedMemory::IPCHandle is a redundant class
https://bugs.webkit.org/show_bug.cgi?id=240056
Attachment 459281: Patch
https://bugs.webkit.org/attachment.cgi?id=459281&action=review
--- Comment #11 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 459281
--> https://bugs.webkit.org/attachment.cgi?id=459281
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=459281&action=review
> Source/WebKit/Shared/WebCompiledContentRuleListData.cpp:47
> + encoder << WTFMove(handle);
encoder << handle;
> Source/WebKit/Shared/WebCoreArgumentCoders.cpp:193
> + encoder << WTFMove(handle);
encoder << handle;
> Source/WebKit/Shared/WebHitTestResultData.cpp:130
> + encoder << WTFMove(imageHandle);
encoder << imageHandle;
> Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:700
> });
WTFMove isn't needed for simple return statements.
return handle;
More information about the webkit-reviews
mailing list