[webkit-reviews] review granted: [Bug 240318] [WebAuthn] Clean up WebAuthenticationModern and WebAuthnProcess : [Attachment 459183] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 12 09:54:01 PDT 2022

Brent Fulgham <bfulgham at webkit.org> has granted j_pascoe at apple.com
<j_pascoe at apple.com>'s request for review:
Bug 240318: [WebAuthn] Clean up WebAuthenticationModern and WebAuthnProcess

Attachment 459183: Patch


--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 459183
  --> https://bugs.webkit.org/attachment.cgi?id=459183

View in context: https://bugs.webkit.org/attachment.cgi?id=459183&action=review

So much cleanup! r=me

> Tools/ChangeLog:-1977
> -	  
(TestWebKitAPI::WebCore::webAuthenticationModernExperimentalFeature): Deleted.

We don't need this ChangeLog comment removal

> Tools/ChangeLog:2011
> +	  
(TestWebKitAPI::WebCore::webAuthenticationModernExperimentalFeature): Deleted.

This seems to be in the wrong part of the file (is perhaps a dupe of the 5/11

> Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:-1437
> -}

Are these two tests really not needed anymore? It doesn't seem like disallowing
the local authenticator is specifically related to the WebAuthn process, is it?

More information about the webkit-reviews mailing list