[webkit-reviews] review granted: [Bug 240229] [GStreamer][VideoCapture] Add support for capturing encoded video streams from a webcam : [Attachment 459216] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 12 09:16:47 PDT 2022

Philippe Normand <pnormand at igalia.com> has granted Loïc Le Page
<llepage at igalia.com>'s request for review:
Bug 240229: [GStreamer][VideoCapture] Add support for capturing encoded video
streams from a webcam

Attachment 459216: Patch


--- Comment #14 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 459216
  --> https://bugs.webkit.org/attachment.cgi?id=459216

View in context: https://bugs.webkit.org/attachment.cgi?id=459216&action=review

>>> Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:71
>>> +	 auto bin = makeGStreamerBin("capsfilter caps=\"video/x-raw\"
name=mimetype-filter ! decodebin3 ! videoscale ! videoconvert ! videorate
drop-only=1 average-period=1 name=videorate", false);
>> So passing true as second argument here wasn't working? Was it due to
> Yes, this is because of decobin3.
> As src pad is a "sometimes" pad the automatic ghost pad was connected to the
videoscale right after and so the mimetype was correctly forced on the first
capsfilter but it was useless as the bin src pad was bypassing it.

Ok then. Maybe later we could rework this part a bit, constructing the bin
manually and handling db3 pads with the pad-added signal. But if this approach
works fine let's land it :)

More information about the webkit-reviews mailing list