[webkit-reviews] review granted: [Bug 104805] Do not allow unitless values for CSS unprefixed perspective property : [Attachment 459232] Patch

[bugzilla-daemon at webkit.org]

Tim Nguyen (:ntim) <ntim at apple.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 104805: Do not allow unitless values for CSS unprefixed perspective
property
https://bugs.webkit.org/show_bug.cgi?id=104805

Attachment 459232: Patch

https://bugs.webkit.org/attachment.cgi?id=459232&action=review




--- Comment #20 from Tim Nguyen (:ntim) <ntim at apple.com> ---
Comment on attachment 459232
  --> https://bugs.webkit.org/attachment.cgi?id=459232
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459232&action=review

> Source/WebCore/css/CSSProperties.json:6715
> +		   "url": "
https://www.w3.org/TR/css-transforms-2/#perspective-property"
> +	       }
> +	   },
> +	   "-webkit-perspective": {
> +	       "codegen-properties": {
> +		   "longhands": [ "perspective" ]
> +	       },
> +	       "specification": {
> +		   "category": "css-transforms",
> +		   "url": "
https://www.w3.org/TR/css-transforms-2/#perspective-property"

nit: The urls have a bogus space before it

also for consistency with the rest of the file, could you give `"perspective"`
its own line in the longhands field?