[webkit-reviews] review granted: [Bug 240302] input.showPicker() should throw when input is readonly/disabled on supported types : [Attachment 459223] Patch

[bugzilla-daemon at webkit.org]

Tim Nguyen (:ntim) <ntim at apple.com> has granted zsun at igalia.com's request for
review:
Bug 240302: input.showPicker() should throw when input is readonly/disabled on
supported types
https://bugs.webkit.org/show_bug.cgi?id=240302

Attachment 459223: Patch

https://bugs.webkit.org/attachment.cgi?id=459223&action=review




--- Comment #8 from Tim Nguyen (:ntim) <ntim at apple.com> ---
Comment on attachment 459223
  --> https://bugs.webkit.org/attachment.cgi?id=459223
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459223&action=review

r=me with the commit message fixed.

> Source/WebCore/ChangeLog:8
> +	   input.showPicker() should throw when input is readonly/disabled on
supported types
> +	   https://bugs.webkit.org/show_bug.cgi?id=240302
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   When input is readonly or disabled on supported types,
input.showPicker() should throw InvalidStateError.

Can you remove the "on supported types" bits? 

I filed bug 240343 to fix the readonly supported types.