[webkit-reviews] review granted: [Bug 240317] TextBoxPainter::paintBackground should bail out early when nothing to paint : [Attachment 459203] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 11 19:47:56 PDT 2022
Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 240317: TextBoxPainter::paintBackground should bail out early when nothing
to paint
https://bugs.webkit.org/show_bug.cgi?id=240317
Attachment 459203: Patch
https://bugs.webkit.org/attachment.cgi?id=459203&action=review
--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 459203
--> https://bugs.webkit.org/attachment.cgi?id=459203
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=459203&action=review
> Source/WebCore/dom/Document.cpp:2891
> + return (m_highlightRegister && !m_highlightRegister->isEmpty()) ||
(m_fragmentHighlightRegister && !m_fragmentHighlightRegister->isEmpty())
I'd wrap the || ... onto a new line, indented.
> Source/WebCore/dom/Document.cpp:2893
> + || (m_appHighlightRegister && m_appHighlightRegister->isEmpty())
Indent this line
More information about the webkit-reviews
mailing list