[webkit-reviews] review granted: [Bug 239591] REGRESSION (r281791): [iOS] WKWebView cannot load local .log file : [Attachment 459187] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 11 16:15:38 PDT 2022
Geoffrey Garen <ggaren at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 239591: REGRESSION (r281791): [iOS] WKWebView cannot load local .log file
https://bugs.webkit.org/show_bug.cgi?id=239591
Attachment 459187: Patch
https://bugs.webkit.org/attachment.cgi?id=459187&action=review
--- Comment #8 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 459187
--> https://bugs.webkit.org/attachment.cgi?id=459187
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=459187&action=review
r=me
Does something specifically prevent us from adding a regression test that loads
a .log file?
> Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.mm:72
> + } else
> #endif // USE(QUICK_LOOK)
> + if (!type)
> + CFURLResponseSetMIMEType(response,
CFSTR("application/octet-stream"));
> }
Super-hard to read an else-if that spans an #ifdef. Can the previous block use
an early return instead?
More information about the webkit-reviews
mailing list