[webkit-reviews] review granted: [Bug 240317] TextBoxPainter::paintBackground should bail out early when nothing to paint : [Attachment 459182] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 11 15:03:40 PDT 2022


Simon Fraser (smfr) <simon.fraser at apple.com> has granted  review:
Bug 240317: TextBoxPainter::paintBackground should bail out early when nothing
to paint
https://bugs.webkit.org/show_bug.cgi?id=240317

Attachment 459182: Patch

https://bugs.webkit.org/attachment.cgi?id=459182&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 459182
  --> https://bugs.webkit.org/attachment.cgi?id=459182
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459182&action=review

> Source/WebCore/rendering/TextBoxPainter.cpp:140
> +	   if (m_document.hasHighlightRegister())

Maybe "has highlight register and has a non-zero number of highlights"?


More information about the webkit-reviews mailing list