[webkit-reviews] review granted: [Bug 240289] Need to add DYLD_LIBRARY_PATH for XPC services : [Attachment 459171] Updated Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 240289: Need to add DYLD_LIBRARY_PATH for XPC services
https://bugs.webkit.org/show_bug.cgi?id=240289

Attachment 459171: Updated Patch

https://bugs.webkit.org/attachment.cgi?id=459171&action=review




--- Comment #8 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 459171
  --> https://bugs.webkit.org/attachment.cgi?id=459171
Updated Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459171&action=review

> Source/WebKit/Configurations/BaseTarget.xcconfig:129
> +OTHER_LDFLAGS_VERSIONED_FRAMEWORK_PATH_YES[arch=arm64*][sdk=macosx11*] =
-Wl,-dyld_env,DYLD_FRAMEWORK_PATH=$(WK_INSTALL_PATH_PREFIX)/System/Library/Stag
edFrameworks/Safari,-dyld_env,DYLD_LIBRARY_PATH=$(WK_INSTALL_PATH_PREFIX)/Syste
m/Library/StagedFrameworks/Safari;

I don't know why there is a special case for macosx11 on Apple Silicon only,
but that's preexisting code, no change.