[webkit-reviews] review granted: [Bug 240292] [LIBPAS] Add extra assert information to malloc enumeration API : [Attachment 459138] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Justin Michaud
<justin_michaud at apple.com>'s request for review:
Bug 240292: [LIBPAS] Add extra assert information to malloc enumeration API
https://bugs.webkit.org/show_bug.cgi?id=240292

Attachment 459138: Patch

https://bugs.webkit.org/attachment.cgi?id=459138&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 459138
  --> https://bugs.webkit.org/attachment.cgi?id=459138
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459138&action=review

r=me with comments.

> Source/bmalloc/ChangeLog:7
> +

Can you describe what is extra compared to PAS_ASSERT_WITH_DETAIL in ChangeLog?
(feature putting values to specific registers before crashing etc.).
And let's also mention to PAS_DEBUG_LOG_TO_SYSLOG's extension.

> Source/bmalloc/libpas/src/libpas/pas_log.c:97
> +#pragma clang diagnostic push
> +#pragma clang diagnostic ignored "-Wformat-nonliteral"

Use `PAS_IGNORE_WARNINGS_BEGIN("format-nonliteral")`

> Source/bmalloc/libpas/src/libpas/pas_log.c:99
> +#pragma clang diagnostic pop

Put PAS_IGNORE_WARNINGS_END

> Source/bmalloc/libpas/src/libpas/pas_utils.c:94
> +	   pas_crash_with_info_impl((uint64_t) format, 0, 0, 0, 0, 0, 0);

Let's remove space between (uint64_t) format

> Source/bmalloc/libpas/src/libpas/pas_utils.c:110
> +    pas_crash_with_info_impl((uint64_t) filename, line, (uint64_t) function,
(uint64_t) expression, 0xbeefbff0, 42, 1337);

Ditto.

> Source/bmalloc/libpas/src/libpas/pas_utils.c:117
> +    pas_crash_with_info_impl((uint64_t) filename, line, (uint64_t) function,
(uint64_t) expression, extra, 1337, 0xbeef0bff);

Ditto.