[webkit-reviews] review granted: [Bug 239989] [cssom] -webkit-text-combine:none serializes as empty string in computed style : [Attachment 459115] Patch

[bugzilla-daemon at webkit.org]

Tim Nguyen (:ntim) <ntim at apple.com> has granted Oriol Brufau
<obrufau at igalia.com>'s request for review:
Bug 239989: [cssom] -webkit-text-combine:none serializes as empty string in
computed style
https://bugs.webkit.org/show_bug.cgi?id=239989

Attachment 459115: Patch

https://bugs.webkit.org/attachment.cgi?id=459115&action=review




--- Comment #3 from Tim Nguyen (:ntim) <ntim at apple.com> ---
Comment on attachment 459115
  --> https://bugs.webkit.org/attachment.cgi?id=459115
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459115&action=review

I originally intentionally changed -webkit-text-combine to be hidden from the
computed style when implementing text-combine-upright since it is non-standard.

But on second thought, we should probably just handle this like any alias.

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:3972
> +	       return cssValuePool.createValue(style.textCombine());

I wonder what we should do if we ever add the digits value support to
text-combine-upright. How would that reflect in -webkit-text-combine?