[webkit-reviews] review granted: [Bug 240244] Remove abandoned CSSDeferredParser implementation and feature flag : [Attachment 459064] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 240244: Remove abandoned CSSDeferredParser implementation and feature flag
https://bugs.webkit.org/show_bug.cgi?id=240244

Attachment 459064: Patch

https://bugs.webkit.org/attachment.cgi?id=459064&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 459064
  --> https://bugs.webkit.org/attachment.cgi?id=459064
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459064&action=review

Nice cleanup!

> Source/WebCore/css/StyleProperties.h:337
>  SPECIALIZE_TYPE_TRAITS_BEGIN(WebCore::StyleProperties)
> -    static bool isType(const WebCore::StylePropertiesBase& set) { return
set.type() != WebCore::DeferredPropertiesType; }
> +    static bool isType(const WebCore::StylePropertiesBase&) { return true; }
>  SPECIALIZE_TYPE_TRAITS_END()

I think we can just remove StylePropertiesBase and smash it into
StyleProperties.

Doesn't need to be done in this patch.