[webkit-reviews] review granted: [Bug 240157] Cache the viewport size inside SVGLengthContext : [Attachment 458972] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 9 12:29:46 PDT 2022
zalan <zalan at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 240157: Cache the viewport size inside SVGLengthContext
https://bugs.webkit.org/show_bug.cgi?id=240157
Attachment 458972: Patch
https://bugs.webkit.org/attachment.cgi?id=458972&action=review
--- Comment #4 from zalan <zalan at apple.com> ---
Comment on attachment 458972
--> https://bugs.webkit.org/attachment.cgi?id=458972
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=458972&action=review
> Source/WebCore/svg/SVGLengthContext.cpp:290
> - return false;
> + return std::nullopt;
return { };
> Source/WebCore/svg/SVGLengthContext.cpp:314
> + return std::nullopt;
here too
More information about the webkit-reviews
mailing list