[webkit-reviews] review granted: [Bug 240109] Implement :modal CSS pseudo-class : [Attachment 459063] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Nguyen (:ntim)
<ntim at apple.com>'s request for review:
Bug 240109: Implement :modal CSS pseudo-class
https://bugs.webkit.org/show_bug.cgi?id=240109

Attachment 459063: Patch

https://bugs.webkit.org/attachment.cgi?id=459063&action=review




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 459063
  --> https://bugs.webkit.org/attachment.cgi?id=459063
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459063&action=review

> Source/WebCore/html/HTMLDialogElement.cpp:169
> +    Style::PseudoClassChangeInvalidation styleInvalidation(*this,
CSSSelector::PseudoClassModal, newValue);
> +    m_isModal = newValue;

Should this check if it has changed?