[webkit-reviews] review granted: [Bug 240212] Introduction.md: Explain active DOM objects : [Attachment 459009] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 9 07:43:10 PDT 2022

Chris Dumez <cdumez at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 240212: Introduction.md: Explain active DOM objects

Attachment 459009: Patch


--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 459009
  --> https://bugs.webkit.org/attachment.cgi?id=459009

View in context: https://bugs.webkit.org/attachment.cgi?id=459009&action=review

This is good but I think we should mention that
ActiveDOMObject::virtualHasPendingActivity() should return true (or we should
be hold a PendingActivity) as long as we may fire events at the object. This is
a big source of confusion for people who sometimes think they only need a
pending activity when they're about to fire an event (e.g. queueing an event).
Fact is if you don't hold a pending activity as soon as your object is created,
then its JS wrapper may get garbage collected before we even get a chance to
queue an event.

>> Introduction.md:1029
>> +In WebKit, we consider these objects has a *pending activity*.
> "these objects has a" doesn't read quite so well.


More information about the webkit-reviews mailing list