[webkit-reviews] review granted: [Bug 240132] Avoid resolving style for elements that only inherit changes from parent : [Attachment 459001] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 240132: Avoid resolving style for elements that only inherit changes from
parent
https://bugs.webkit.org/show_bug.cgi?id=240132

Attachment 459001: Patch

https://bugs.webkit.org/attachment.cgi?id=459001&action=review




--- Comment #7 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 459001
  --> https://bugs.webkit.org/attachment.cgi?id=459001
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459001&action=review

> Source/WebCore/ChangeLog:10
> +	   is done by simply running the full style resolution for them
sincluding selector matching and

typo: sincluding -> including

> Source/WebCore/ChangeLog:13
> +	   In a common case nothing changes in descendants expect the inherited
properties. This patch implements

typo. "In a common case" usually we say "In the common case".

> Source/WebCore/css/CSSProperties.json:96
> +	   "Indicates that this CSS property can use fast-path inheritance
mechanism.",

"Indicates that this CSS property can use fast-path inheritance mechanism.", ->
"Indicates that this CSS property can use the fast-path inheritance
mechanism.",