[webkit-reviews] review granted: [Bug 240184] Fix adattributiond build in internal build on older macOS : [Attachment 458974] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 6 14:28:46 PDT 2022
Alexey Proskuryakov <ap at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 240184: Fix adattributiond build in internal build on older macOS
https://bugs.webkit.org/show_bug.cgi?id=240184
Attachment 458974: Patch
https://bugs.webkit.org/attachment.cgi?id=458974&action=review
--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 458974
--> https://bugs.webkit.org/attachment.cgi?id=458974
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=458974&action=review
> Source/WebKit/Configurations/adattributiond.xcconfig:24
> +#include "Base.xcconfig"
This is not necessary, please remove. Xcode project includes either
Base.xcconfing or DebugRelease.xcconfig for all projects.
More information about the webkit-reviews
mailing list