[webkit-reviews] review granted: [Bug 240178] [macOS] Content filter blocking shield is not displayed : [Attachment 458966] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 6 14:09:52 PDT 2022
Geoffrey Garen <ggaren at apple.com> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 240178: [macOS] Content filter blocking shield is not displayed
https://bugs.webkit.org/show_bug.cgi?id=240178
Attachment 458966: Patch
https://bugs.webkit.org/attachment.cgi?id=458966&action=review
--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 458966
--> https://bugs.webkit.org/attachment.cgi?id=458966
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=458966&action=review
r=me
> Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:185
> + auto unblocked = false;
> + callOnMainThread([decisionHandler, unblocked] {
> + decisionHandler(unblocked);
> + });
Can unblocked be a local variable rather than a captured variable here?
More information about the webkit-reviews
mailing list