[webkit-reviews] review granted: [Bug 240175] WebKit has a broken module in Mac Catalyst : [Attachment 458964] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Ian Anderson <iana at apple.com>'s
request for review:
Bug 240175: WebKit has a broken module in Mac Catalyst
https://bugs.webkit.org/show_bug.cgi?id=240175

Attachment 458964: Patch

https://bugs.webkit.org/attachment.cgi?id=458964&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 458964
  --> https://bugs.webkit.org/attachment.cgi?id=458964
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458964&action=review

> Source/WebKit/Configurations/WebKit.xcconfig:35
> +MODULEMAP_FILE = $(MODULEMAP_FILE_$(WK_COCOA_TOUCH)_$(WK_IS_CATALYST));
> +MODULEMAP_FILE_cocoatouch_NO = Modules/iOS.modulemap;
> +MODULEMAP_FILE_cocoatouch_YES = Modules/MacCatalyst.modulemap;
> +MODULEMAP_FILE__NO = Modules/OSX.modulemap;

This is fine, though I think usually when we want to make this distinction we
fall back to WK_PLATFORM_NAME instead (but, I admit, that would involve a lot
more duplication).