[webkit-reviews] review granted: [Bug 240156] Make the various shouldApplyContainment() functions member functions on RenderElement : [Attachment 458932] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 240156: Make the various shouldApplyContainment() functions member
functions on RenderElement
https://bugs.webkit.org/show_bug.cgi?id=240156

Attachment 458932: Patch

https://bugs.webkit.org/attachment.cgi?id=458932&action=review




--- Comment #2 from zalan <zalan at apple.com> ---
Comment on attachment 458932
  --> https://bugs.webkit.org/attachment.cgi?id=458932
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458932&action=review

> Source/WebCore/rendering/RenderElement.h:505
> +inline bool RenderElement::shouldApplyLayoutContainment() const
> +{
> +    return style().containsLayout() && (!isInline() ||
isAtomicInlineLevelBox()) && !isRubyText() && (!isTablePart() ||
isRenderBlockFlow());
> +}

at some point these could all be moved to RenderBlock (or maybe even
RenderBlockFlow) since the current render tree has this built-in type
information. super not important -and also LFC tree does not work like that
either.