[webkit-reviews] review granted: [Bug 240159] [WebGPU] Fix build on downlevel OSes in Apple's build system : [Attachment 458938] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 6 08:39:29 PDT 2022

Alexey Proskuryakov <ap at webkit.org> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 240159: [WebGPU] Fix build on downlevel OSes in Apple's build system

Attachment 458938: Patch


--- Comment #4 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 458938
  --> https://bugs.webkit.org/attachment.cgi?id=458938

View in context: https://bugs.webkit.org/attachment.cgi?id=458938&action=review

> Source/WebGPU/Configurations/Base.xcconfig:27
> +#include?
>  #include "SDKVariant.xcconfig"
> +#include "WebKitTargetConditionals.xcconfig"

I see that for WebCore, these are in WebCore.xcconfig, not in Base.xcconfig. Is
it possible to keep these projects similar, to reduce future confusion?

More information about the webkit-reviews mailing list