[webkit-reviews] review granted: [Bug 239952] MotionMark design subtest doesn't look right with GPUP DOM rendering enabled : [Attachment 458936] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Cameron McCormack (:heycam)
<heycam at apple.com>'s request for review:
Bug 239952: MotionMark design subtest doesn't look right with GPUP DOM
rendering enabled
https://bugs.webkit.org/show_bug.cgi?id=239952

Attachment 458936: Patch

https://bugs.webkit.org/attachment.cgi?id=458936&action=review




--- Comment #11 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 458936
  --> https://bugs.webkit.org/attachment.cgi?id=458936
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458936&action=review

> Source/WebCore/testing/Internals.cpp:3287
> +void Internals::setForceUseGlyphDisplayListForTesting(bool enabled)
> +{
> +    TextPainter::setForceUseGlyphDisplayListForTesting(enabled);
> +}

Internals::resetToConsistentState should probably reset this (so it doesn't get
stuck in the process if the test somehow fails).