[webkit-reviews] review granted: [Bug 239852] ARIA reflection for Element attributes : [Attachment 458872] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 5 11:32:17 PDT 2022

Ryosuke Niwa <rniwa at webkit.org> has granted Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 239852: ARIA reflection for Element attributes

Attachment 458872: Patch


--- Comment #33 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 458872
  --> https://bugs.webkit.org/attachment.cgi?id=458872

View in context: https://bugs.webkit.org/attachment.cgi?id=458872&action=review

> Source/WebCore/dom/Element.h:679
> +    ExplicitlySetAttrElementsMap& ensureExplicitlySetAttrElementsMap();
> +    ExplicitlySetAttrElementsMap* explicitlySetAttrElementsMap() const;
> +

The agreed upon naming convention is:
ExplicitlySetAttrElementsMap& explicitlySetAttrElementsMap();
ExplicitlySetAttrElementsMap* explicitlySetAttrElementsMapIfExists() const;

More information about the webkit-reviews mailing list