[webkit-reviews] review granted: [Bug 240118] Remove usage of PixelBufferConformer in RealtimeOutgoingVideoSourceCocoa : [Attachment 458867] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted  review:
Bug 240118: Remove usage of PixelBufferConformer in
RealtimeOutgoingVideoSourceCocoa
https://bugs.webkit.org/show_bug.cgi?id=240118

Attachment 458867: Patch

https://bugs.webkit.org/attachment.cgi?id=458867&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 458867
  --> https://bugs.webkit.org/attachment.cgi?id=458867
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458867&action=review

r=me once the bots are happy

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitUtilities.mm:251
> +    auto result =
libyuv::ARGBToI420(static_cast<uint8_t*>(CVPixelBufferGetBaseAddress(pixelBuffe
r)),

The function name suggests it converts BGRA to YUV, but it calls a function
that seems to convert ARGB to YUV. Is this correct?