[webkit-reviews] review granted: [Bug 240113] Allow MediaPlayerPrivateMediaStreamAVFObjC to avoid pixel conformers if IOSurfaces are not allowed : [Attachment 458865] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted  review:
Bug 240113: Allow MediaPlayerPrivateMediaStreamAVFObjC to avoid pixel
conformers if IOSurfaces are not allowed
https://bugs.webkit.org/show_bug.cgi?id=240113

Attachment 458865: Patch

https://bugs.webkit.org/attachment.cgi?id=458865&action=review




--- Comment #6 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 458865
  --> https://bugs.webkit.org/attachment.cgi?id=458865
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458865&action=review

r=me once the bots are happy

> Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.cpp:142
> +	  
m_connection->send(Messages::RemoteVideoFrameObjectHeapProxyProcessor::NewConve
rtedVideoFrameBuffer { { } }, 0);

It looks like SharedVideoFrameReader doesn't log errors, so it might be worth
logging an error here to help debug unexpected failures.

> Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.cpp:149
> +	  
m_connection->send(Messages::RemoteVideoFrameObjectHeapProxyProcessor::NewConve
rtedVideoFrameBuffer { { } }, 0);

Ditto, PixelBufferConformerCV also doesn't log failures.

> Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.mm:32
> +

Nit: unneeded white space